Change in libosmocore[master]: stat_item: make value ids item specific

osmith gerrit-no-reply at lists.osmocom.org
Fri Mar 26 17:20:25 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23508 )

Change subject: stat_item: make value ids item specific
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/23508/1/include/osmocom/core/stat_item.h 
File include/osmocom/core/stat_item.h:

https://gerrit.osmocom.org/c/libosmocore/+/23508/1/include/osmocom/core/stat_item.h@30 
PS1, Line 30: stats_next_id
This might be controversial. As stated in the commit message, I think this is fine, because this is always -1 in current code (and has been that way since right after stats were introduced in 2015), so nothing can really use it in current form.

  $ git grep last_value_index
  include/osmocom/core/stat_item.h:       int32_t last_value_index;
  src/stat_item.c:                item->last_value_index = -1;
  src/stat_item.c:        item->last_value_index = -1;



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23508
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie65dcdf52c8fc3d916e20d7f0455f6223be6b64f
Gerrit-Change-Number: 23508
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Fri, 26 Mar 2021 17:20:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210326/983ee23e/attachment.htm>


More information about the gerrit-log mailing list