<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23508">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23508/1/include/osmocom/core/stat_item.h">File include/osmocom/core/stat_item.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/23508/1/include/osmocom/core/stat_item.h@30">Patch Set #1, Line 30:</a> <code style="font-family:monospace,monospace">stats_next_id</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This might be controversial. As stated in the commit message, I think this is fine, because this is always -1 in current code (and has been that way since right after stats were introduced in 2015), so nothing can really use it in current form.</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  $ git grep last_value_index<br>  include/osmocom/core/stat_item.h:       int32_t last_value_index;<br>  src/stat_item.c:                item->last_value_index = -1;<br>  src/stat_item.c:        item->last_value_index = -1;</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23508">change 23508</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23508"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie65dcdf52c8fc3d916e20d7f0455f6223be6b64f </div>
<div style="display:none"> Gerrit-Change-Number: 23508 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 26 Mar 2021 17:20:25 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>