This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23499 ) Change subject: gmm: Send event E_PMM_PS_CONN_ESTABLISH upon rx GMM SERVICE REQUEST ...................................................................... gmm: Send event E_PMM_PS_CONN_ESTABLISH upon rx GMM SERVICE REQUEST Attach event should only be triggered by rx Attach Request, not other messages. Furthermore, currently E_PMM_PS_CONN_ESTABLISH is defined and expected in FSM but not sent by anyone. Also, The opposite transition is done by E_PMM_PS_CONN_RELEASE: """ MM_STATE_Iu(0)[0x81379b0]{Connected}: Received Event E_PMM_PS_CONN_RELEASE MM_STATE_Iu(0)[0x81379b0]{Connected}: state_chg to Idle ... MM(001010123456063/c8b8bd08) -> GMM SERVICE REQUEST MI(3367550216) type="signalling" MM_STATE_Iu(0)[0x81379b0]{Idle}: Received Event E_PMM_PS_ATTACH MM_STATE_Iu(0)[0x81379b0]{Idle}: Event E_PMM_PS_ATTACH not permitted """ Related: SYS#5389 Change-Id: Ica00891f91834522f4dea2508b62af34e4c4eca7 --- M src/sgsn/gprs_gmm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/99/23499/1 diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index 2ba6d08..545c8e7 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -936,7 +936,7 @@ #ifdef BUILD_IU case GSM48_MT_GMM_SERVICE_REQ: ctx->pending_req = 0; - osmo_fsm_inst_dispatch(ctx->iu.mm_state_fsm, E_PMM_PS_ATTACH, NULL); + osmo_fsm_inst_dispatch(ctx->iu.mm_state_fsm, E_PMM_PS_CONN_ESTABLISH, NULL); rc = gsm48_tx_gmm_service_ack(ctx); if (ctx->iu.service.type != GPRS_SERVICE_T_SIGNALLING) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/23499 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ica00891f91834522f4dea2508b62af34e4c4eca7 Gerrit-Change-Number: 23499 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210325/0d3e76d9/attachment.htm>