<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/23499">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gmm: Send event E_PMM_PS_CONN_ESTABLISH upon rx GMM SERVICE REQUEST<br><br>Attach event should only be triggered by rx Attach Request, not other<br>messages. Furthermore, currently E_PMM_PS_CONN_ESTABLISH is defined and<br>expected in FSM but not sent by anyone.<br>Also, The opposite transition is done by E_PMM_PS_CONN_RELEASE:<br><br>"""<br>MM_STATE_Iu(0)[0x81379b0]{Connected}: Received Event E_PMM_PS_CONN_RELEASE<br>MM_STATE_Iu(0)[0x81379b0]{Connected}: state_chg to Idle<br>...<br>MM(001010123456063/c8b8bd08) -> GMM SERVICE REQUEST MI(3367550216) type="signalling"<br>MM_STATE_Iu(0)[0x81379b0]{Idle}: Received Event E_PMM_PS_ATTACH<br>MM_STATE_Iu(0)[0x81379b0]{Idle}: Event E_PMM_PS_ATTACH not permitted<br>"""<br><br>Related: SYS#5389<br>Change-Id: Ica00891f91834522f4dea2508b62af34e4c4eca7<br>---<br>M src/sgsn/gprs_gmm.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/99/23499/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c</span><br><span>index 2ba6d08..545c8e7 100644</span><br><span>--- a/src/sgsn/gprs_gmm.c</span><br><span>+++ b/src/sgsn/gprs_gmm.c</span><br><span>@@ -936,7 +936,7 @@</span><br><span> #ifdef BUILD_IU</span><br><span>    case GSM48_MT_GMM_SERVICE_REQ:</span><br><span>               ctx->pending_req = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-                osmo_fsm_inst_dispatch(ctx->iu.mm_state_fsm, E_PMM_PS_ATTACH, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+               osmo_fsm_inst_dispatch(ctx->iu.mm_state_fsm, E_PMM_PS_CONN_ESTABLISH, NULL);</span><br><span>              rc = gsm48_tx_gmm_service_ack(ctx);</span><br><span> </span><br><span>              if (ctx->iu.service.type != GPRS_SERVICE_T_SIGNALLING)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/23499">change 23499</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/23499"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ica00891f91834522f4dea2508b62af34e4c4eca7 </div>
<div style="display:none"> Gerrit-Change-Number: 23499 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>