This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23494 ) Change subject: pcu: Adapt N3101_MAX verification expectancies ...................................................................... pcu: Adapt N3101_MAX verification expectancies There's some offset between Tx and Rx path, so we need to account for differences counting and finding out USF blocks didn't arrive. Change-Id: I868e7d24c8bdc9b85797f8fe4f9ee1bc5a3d1adb --- M pcu/PCU_Tests.ttcn 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/94/23494/1 diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 5f60cef..187e2f1 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -1365,12 +1365,11 @@ if (rx_usf == ms.ul_tbf.usf[valueof(nr.ts_nr)]) { log("PCU requests our USF ", rx_usf, ", n3101=", n3101); n3101 := n3101 + 1; - //"if (n3101 > N3101_MAX) {" -> start timer T3169 - if (n3101 > N3101_MAX) { - setverdict(fail, "Reached ", n3101, " > ", N3101_MAX, " (N3101_MAX) and PCU still sends us USFs"); + if (n3101 > N3101_MAX + 1) { //+1: DL<->UL FN offset + setverdict(fail, "Reached ", n3101, " > ", N3101_MAX + 1, " (N3101_MAX+1) and PCU still sends us USFs"); f_shutdown(__BFILE__, __LINE__); } - } else if (rx_usf == USF_UNUSED and n3101 == N3101_MAX) { + } else if (rx_usf == USF_UNUSED and n3101 == N3101_MAX + 1) { /* If we already received USFs for us and we don't receive them anymore, that means the TBF entered T3169 */ log("PCU stopped requesting USF ", ms.ul_tbf.usf[valueof(nr.ts_nr)]); if (not T_3169.running) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23494 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I868e7d24c8bdc9b85797f8fe4f9ee1bc5a3d1adb Gerrit-Change-Number: 23494 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210324/dcd94288/attachment.htm>