<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23494">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu: Adapt N3101_MAX verification expectancies<br><br>There's some offset between Tx and Rx path, so we need to account for<br>differences counting and finding out USF blocks didn't arrive.<br><br>Change-Id: I868e7d24c8bdc9b85797f8fe4f9ee1bc5a3d1adb<br>---<br>M pcu/PCU_Tests.ttcn<br>1 file changed, 3 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/94/23494/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index 5f60cef..187e2f1 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -1365,12 +1365,11 @@</span><br><span>                 if (rx_usf == ms.ul_tbf.usf[valueof(nr.ts_nr)]) {</span><br><span>                    log("PCU requests our USF ", rx_usf, ", n3101=", n3101);</span><br><span>                         n3101 := n3101 + 1;</span><br><span style="color: hsl(0, 100%, 40%);">-                     //"if (n3101 > N3101_MAX) {" -> start timer T3169</span><br><span style="color: hsl(0, 100%, 40%);">-                       if (n3101 > N3101_MAX) {</span><br><span style="color: hsl(0, 100%, 40%);">-                             setverdict(fail, "Reached ", n3101, " > ", N3101_MAX, " (N3101_MAX) and PCU still sends us USFs");</span><br><span style="color: hsl(120, 100%, 40%);">+                   if (n3101 > N3101_MAX + 1) { //+1: DL<->UL FN offset</span><br><span style="color: hsl(120, 100%, 40%);">+                         setverdict(fail, "Reached ", n3101, " > ", N3101_MAX + 1, " (N3101_MAX+1) and PCU still sends us USFs");</span><br><span>                            f_shutdown(__BFILE__, __LINE__);</span><br><span>                     }</span><br><span style="color: hsl(0, 100%, 40%);">-               } else if (rx_usf == USF_UNUSED and n3101 == N3101_MAX) {</span><br><span style="color: hsl(120, 100%, 40%);">+             } else if (rx_usf == USF_UNUSED and n3101 == N3101_MAX + 1) {</span><br><span>                        /* If we already received USFs for us and we don't receive them anymore, that means the TBF entered T3169 */</span><br><span>                     log("PCU stopped requesting USF ", ms.ul_tbf.usf[valueof(nr.ts_nr)]);</span><br><span>                      if (not T_3169.running) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23494">change 23494</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23494"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I868e7d24c8bdc9b85797f8fe4f9ee1bc5a3d1adb </div>
<div style="display:none"> Gerrit-Change-Number: 23494 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>