Change in osmo-bsc[master]: fix/refactor neighbor config

pespin gerrit-no-reply at lists.osmocom.org
Wed Mar 24 15:19:15 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23360 )

Change subject: fix/refactor neighbor config
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/23360/2/include/osmocom/bsc/neighbor_ident.h 
File include/osmocom/bsc/neighbor_ident.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/23360/2/include/osmocom/bsc/neighbor_ident.h@57 
PS2, Line 57: int resolve_local_neighbor(struct gsm_bts **local_neighbor_p, struct gsm_bts *from_bts,
from_bts can probably be const.


https://gerrit.osmocom.org/c/osmo-bsc/+/23360/2/src/osmo-bsc/neighbor_ident.c 
File src/osmo-bsc/neighbor_ident.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/23360/2/src/osmo-bsc/neighbor_ident.c@426 
PS2, Line 426: 	if (local_neighbor) {
AFAIU this will never be false since if resolve_neighbor fails, the pointer is NULL, otherwise it's not NULL (and btw you are not initializing the pointer to null at the start of the function, which *may* make some gcc versions unhappy).


https://gerrit.osmocom.org/c/osmo-bsc/+/23360/2/src/osmo-bsc/neighbor_ident.c@433 
PS2, Line 433: 	    && remote_neighbors.id_discr == CELL_IDENT_WHOLE_GLOBAL_PS) {
I find interesting that you prefer putting the "&&" at the start of the line while I prefer putting them at the end :) (not asking you to change it)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23360
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9ed992f8bfff888b3933733c0576f92d50f2625b
Gerrit-Change-Number: 23360
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 24 Mar 2021 15:19:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210324/5d263310/attachment.htm>


More information about the gerrit-log mailing list