<p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23360">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23360/2/include/osmocom/bsc/neighbor_ident.h">File include/osmocom/bsc/neighbor_ident.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23360/2/include/osmocom/bsc/neighbor_ident.h@57">Patch Set #2, Line 57:</a> <code style="font-family:monospace,monospace">int resolve_local_neighbor(struct gsm_bts **local_neighbor_p, struct gsm_bts *from_bts,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">from_bts can probably be const.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23360/2/src/osmo-bsc/neighbor_ident.c">File src/osmo-bsc/neighbor_ident.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23360/2/src/osmo-bsc/neighbor_ident.c@426">Patch Set #2, Line 426:</a> <code style="font-family:monospace,monospace">    if (local_neighbor) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">AFAIU this will never be false since if resolve_neighbor fails, the pointer is NULL, otherwise it's not NULL (and btw you are not initializing the pointer to null at the start of the function, which *may* make some gcc versions unhappy).</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23360/2/src/osmo-bsc/neighbor_ident.c@433">Patch Set #2, Line 433:</a> <code style="font-family:monospace,monospace">          && remote_neighbors.id_discr == CELL_IDENT_WHOLE_GLOBAL_PS) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I find interesting that you prefer putting the "&&" at the start of the line while I prefer putting them at the end :) (not asking you to change it)</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23360">change 23360</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/23360"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9ed992f8bfff888b3933733c0576f92d50f2625b </div>
<div style="display:none"> Gerrit-Change-Number: 23360 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 24 Mar 2021 15:19:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>