Change in libosmocore[master]: gprs_ns2: Introduce gprs_ns2_create_nse2() for SGSN side SNS

laforge gerrit-no-reply at lists.osmocom.org
Sat Mar 20 10:57:33 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23407 )

Change subject: gprs_ns2: Introduce gprs_ns2_create_nse2() for SGSN side SNS
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/23407/1/src/gb/gprs_ns2.c 
File src/gb/gprs_ns2.c:

https://gerrit.osmocom.org/c/libosmocore/+/23407/1/src/gb/gprs_ns2.c@783 
PS1, Line 783: 					  bool local_sgsn_role)
> iirc there was enum type for role, maybe better pass that?
the role enum is an internal part of the implementation, and is not exposed to the API user. Given that there are no more roles than those two, I think the bool is fine inthe API.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23407
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6db8c36f7c69b592d7d0fbcf323804f7e9912be2
Gerrit-Change-Number: 23407
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 20 Mar 2021 10:57:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210320/bdc673bf/attachment.htm>


More information about the gerrit-log mailing list