Change in libosmocore[master]: gprs_ns2: Introduce gprs_ns2_create_nse2() for SGSN side SNS

pespin gerrit-no-reply at lists.osmocom.org
Fri Mar 19 15:17:03 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23407 )

Change subject: gprs_ns2: Introduce gprs_ns2_create_nse2() for SGSN side SNS
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/23407/1/src/gb/gprs_ns2.c 
File src/gb/gprs_ns2.c:

https://gerrit.osmocom.org/c/libosmocore/+/23407/1/src/gb/gprs_ns2.c@783 
PS1, Line 783: 					  bool local_sgsn_role)
iirc there was enum type for role, maybe better pass that?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23407
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6db8c36f7c69b592d7d0fbcf323804f7e9912be2
Gerrit-Change-Number: 23407
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Mar 2021 15:17:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210319/b0b305d4/attachment.htm>


More information about the gerrit-log mailing list