Change in osmo-pcu[master]: bts: Detect FN jumps

pespin gerrit-no-reply at lists.osmocom.org
Fri Mar 12 14:12:38 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23314 )

Change subject: bts: Detect FN jumps
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/23314/3/src/bts.cpp 
File src/bts.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/23314/3/src/bts.cpp@335 
PS3, Line 335: bts_current_frame_number(bts) == 0
> Are you sure this is correct? AFAICS, you're now using 0xffffffff as 'not set'. […]
Indeed, thanks for pointing out.


https://gerrit.osmocom.org/c/osmo-pcu/+/23314/3/tests/tbf/TbfTest.err 
File tests/tbf/TbfTest.err:

https://gerrit.osmocom.org/c/osmo-pcu/+/23314/3/tests/tbf/TbfTest.err@1519 
PS3, Line 1519: Detected FN jump! 2654167 -> 2654270
> Is this also expected?
Yes, tests are not properly (nor care sometimes) about properly updating the clock every time, since they don't need it to accomplish what they test.
These lines being printed actually mean the detection seems to be working :)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23314
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I29fb27981597edc69abb976049ba41aa840488cb
Gerrit-Change-Number: 23314
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Fri, 12 Mar 2021 14:12:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210312/f940aeb3/attachment.htm>


More information about the gerrit-log mailing list