Change in osmo-pcu[master]: bts: Detect FN jumps

fixeria gerrit-no-reply at lists.osmocom.org
Fri Mar 12 13:47:46 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23314 )

Change subject: bts: Detect FN jumps
......................................................................


Patch Set 3:

(4 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/23314/3/src/bts.h 
File src/bts.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/23314/3/src/bts.h@278 
PS3, Line 278: TODO: change the number to unsigned
Can this TODO be removed now?


https://gerrit.osmocom.org/c/osmo-pcu/+/23314/3/src/bts.cpp 
File src/bts.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/23314/3/src/bts.cpp@247 
PS3, Line 247: (uint32_t)-1
Let's use 0xffffffff or better a macro for that.


https://gerrit.osmocom.org/c/osmo-pcu/+/23314/3/src/bts.cpp@335 
PS3, Line 335: bts_current_frame_number(bts) == 0
Are you sure this is correct? AFAICS, you're now using 0xffffffff as 'not set'.
I am asking because this (IMHO, useless) function basically returns bts->cur_fn.


https://gerrit.osmocom.org/c/osmo-pcu/+/23314/3/tests/tbf/TbfTest.err 
File tests/tbf/TbfTest.err:

https://gerrit.osmocom.org/c/osmo-pcu/+/23314/3/tests/tbf/TbfTest.err@1519 
PS3, Line 1519: Detected FN jump! 2654167 -> 2654270
Is this also expected?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23314
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I29fb27981597edc69abb976049ba41aa840488cb
Gerrit-Change-Number: 23314
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Fri, 12 Mar 2021 13:47:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210312/0d8a89f4/attachment.htm>


More information about the gerrit-log mailing list