Change in docker-playground[master]: Make respawn.sh a common part of *-build/-obs images
gerrit-no-reply at lists.osmocom.org
Wed Mar 10 00:12:25 UTC 2021
fixeria has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/c/docker-playground/+/23303 )
Change subject: Make respawn.sh a common part of *-build/-obs images
Make respawn.sh a common part of *-build/-obs images
Maintaining several versions of the same file in different folders
is a bad idea, because at some point their content gets out of sync.
This is exactly what happened to 'respawn.sh': sleep()ing was only
implemented in 'osmo-bts-master/respawn.sh', other versions of this
file would simply ignore '$SLEEP_BEFORE_RESPAWN'.
The easiest solution would be to have all common files in a single
directory, however Docker does not allow to ADD files from outside
of the build context. In other words, all files must be in the
same directory as the Dockerfile itself.
At the same time, Docker allows the first argument of ADD to be
a URL, and at least HTTP(S) is supported. Most of our images
require the Internet connectivity anyway, so let's make it grab
'respawn.sh' from https://git.osmocom.org/docker-playground/.
14 files changed, 18 insertions(+), 53 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/03/23303/3
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/23303
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log