This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23250 ) Change subject: pcu: Fix PCU_Tests_SNS.TC_sns_so_bvc_reset_unknown_bvci ...................................................................... pcu: Fix PCU_Tests_SNS.TC_sns_so_bvc_reset_unknown_bvci All BSS-originated BVC-Reset for PTP BVC must contain a Cell Identifier. This test is not respecting that rule libosmogb correctly detects this and discards the RESET, which is not what is intended here: 20210305120722368 DLBSSGP ERROR BSSGP BVCI=1235 Rx RESET missing mandatory IE (gprs_bssgp.c:392) Change-Id: I57ebfc50befc47d0690021d73b52c504f0df4f9a Related: OS#3879 Fixes: Iea5519b453dd544c5a78b3b16ddb5132d20cf67c --- M pcu/PCU_Tests_SNS.ttcn 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/50/23250/1 diff --git a/pcu/PCU_Tests_SNS.ttcn b/pcu/PCU_Tests_SNS.ttcn index 34aec72..b63b51e 100644 --- a/pcu/PCU_Tests_SNS.ttcn +++ b/pcu/PCU_Tests_SNS.ttcn @@ -278,8 +278,10 @@ f_ns_exp(pdu); /* Send a BVC-RESET on the wrong BVC */ - var PDU_BSSGP bssgp_tx := valueof(ts_BVC_RESET(BSSGP_CAUSE_NET_SV_CAP_MOD_GT_ZERO_KBPS, mp_gb_cfg.bvc[0].bvci + 1, - omit)); + var BssgpCellId cell_id := mp_gb_cfg.bvc[0].cell_id; + cell_id.cell_id := cell_id.cell_id + 1; + var PDU_BSSGP bssgp_tx := valueof(ts_BVC_RESET(BSSGP_CAUSE_NET_SV_CAP_MOD_GT_ZERO_KBPS, + mp_gb_cfg.bvc[0].bvci + 1, cell_id)); NSCP[0].send(ts_NS_UNITDATA(t_SduCtrlB, 0, enc_PDU_BSSGP(bssgp_tx))); NSCP[0].receive(tr_NS_UNITDATA(t_SduCtrlB, 0, decmatch tr_BSSGP_STATUS(mp_gb_cfg.bvc[0].bvci + 1, BSSGP_CAUSE_BVCI_UNKNOWN, *))); setverdict(pass); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I57ebfc50befc47d0690021d73b52c504f0df4f9a Gerrit-Change-Number: 23250 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210305/33cd74ae/attachment.htm>