<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23250">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu: Fix PCU_Tests_SNS.TC_sns_so_bvc_reset_unknown_bvci<br><br>All BSS-originated BVC-Reset for PTP BVC must contain a Cell Identifier.<br>This test is not respecting that rule<br><br>libosmogb correctly detects this and discards the RESET, which is not<br>what is intended here:<br><br>20210305120722368 DLBSSGP ERROR BSSGP BVCI=1235 Rx RESET missing mandatory IE (gprs_bssgp.c:392)<br><br>Change-Id: I57ebfc50befc47d0690021d73b52c504f0df4f9a<br>Related: OS#3879<br>Fixes: Iea5519b453dd544c5a78b3b16ddb5132d20cf67c<br>---<br>M pcu/PCU_Tests_SNS.ttcn<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/50/23250/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/PCU_Tests_SNS.ttcn b/pcu/PCU_Tests_SNS.ttcn</span><br><span>index 34aec72..b63b51e 100644</span><br><span>--- a/pcu/PCU_Tests_SNS.ttcn</span><br><span>+++ b/pcu/PCU_Tests_SNS.ttcn</span><br><span>@@ -278,8 +278,10 @@</span><br><span>   f_ns_exp(pdu);</span><br><span> </span><br><span>   /* Send a BVC-RESET on the wrong BVC */</span><br><span style="color: hsl(0, 100%, 40%);">- var PDU_BSSGP bssgp_tx := valueof(ts_BVC_RESET(BSSGP_CAUSE_NET_SV_CAP_MOD_GT_ZERO_KBPS, mp_gb_cfg.bvc[0].bvci + 1,</span><br><span style="color: hsl(0, 100%, 40%);">-                                                     omit));</span><br><span style="color: hsl(120, 100%, 40%);">+        var BssgpCellId cell_id := mp_gb_cfg.bvc[0].cell_id;</span><br><span style="color: hsl(120, 100%, 40%);">+  cell_id.cell_id := cell_id.cell_id + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+       var PDU_BSSGP bssgp_tx := valueof(ts_BVC_RESET(BSSGP_CAUSE_NET_SV_CAP_MOD_GT_ZERO_KBPS,</span><br><span style="color: hsl(120, 100%, 40%);">+                                                       mp_gb_cfg.bvc[0].bvci + 1, cell_id));</span><br><span>        NSCP[0].send(ts_NS_UNITDATA(t_SduCtrlB, 0, enc_PDU_BSSGP(bssgp_tx)));</span><br><span>        NSCP[0].receive(tr_NS_UNITDATA(t_SduCtrlB, 0, decmatch tr_BSSGP_STATUS(mp_gb_cfg.bvc[0].bvci + 1, BSSGP_CAUSE_BVCI_UNKNOWN, *)));</span><br><span>    setverdict(pass);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23250">change 23250</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23250"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I57ebfc50befc47d0690021d73b52c504f0df4f9a </div>
<div style="display:none"> Gerrit-Change-Number: 23250 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>