Change in osmo-bsc[master]: stats: add BTS uptime counter
gerrit-no-reply at lists.osmocom.org
Thu Mar 4 13:38:49 UTC 2021
iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23234 )
Change subject: stats: add BTS uptime counter
Patch Set 1:
> I'm not really liking this approach. I think you are abusing the CTR/stats to store some information which doesn't belong here.
Thanks for the review. I agree this approach is not yet acceptable. However, I do think that storing BTS uptime in the stats system is a valid use of the stats system and a desirable feature for many people. It is shown in the VTY output alongside other metrics already recorded in stat counters. My goal here is to efficiently translate that uptime output into a new statsd counter.
> First of all, the way you count uptime is for sure going to skew after a while from real time, since you don't account for delays in timer scheduling (so let's say you sum 1 second to counter, but you are doing that after eg 1.00XXX seconds every time).
> Second, "uptime" to me doesn't mean all TRX are unlocked, I would think "uptime" more as "at least 1 TRX serving".
I can add precise increments to the counter based on actual elapsed time and not rely on timer scheduling. I can also change uptime to represent your suggestion of "at least 1 TRX serving".
Let me know if there is, in general, a more preferable way to add these "non-event" driven metrics to the stats counters. For now I will improve the two things you mention.
Thanks again for your time,
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23234
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: iedemam <michael at kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Mar 2021 13:38:49 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log