Change in osmo-bsc[master]: stats: add BTS uptime counter

pespin gerrit-no-reply at lists.osmocom.org
Thu Mar 4 13:26:40 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23234 )

Change subject: stats: add BTS uptime counter
......................................................................


Patch Set 1: Code-Review-1

I'm not really liking this approach. I think you are abusing the CTR/stats to store some information which doesn't belong here.
First of all, the way you count uptime is for sure going to skew after a while from real time, since you don't account for delays in timer scheduling (so let's say you sum 1 second to counter, but you are doing that after eg 1.00XXX seconds every time).
Second, "uptime" to me doesn't mean all TRX are unlocked, I would think "uptime" more as "at least 1 TRX serving".

In any case, as I said, I have my doubts using counters for counting time is the way to go. IIRC there's already a CTRL command to get the uptime or the status of a given BTS. If you need more speciifc information, you can add new CTRL commands for that (eg uptime start timestamp stored per BTS and then now() - timestmap is provided).


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23234
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib17674bbe95e828cebff12de9e0b30f06447ef6c
Gerrit-Change-Number: 23234
Gerrit-PatchSet: 1
Gerrit-Owner: iedemam <michael at kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Mar 2021 13:26:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210304/cd855c33/attachment.htm>


More information about the gerrit-log mailing list