Change in libosmocore[master]: gprs_bssgp: use BVCI_SIGNALLING/BVCI_PTM instead of 0/1

laforge gerrit-no-reply at lists.osmocom.org
Mon Mar 1 19:44:03 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23013 )

Change subject: gprs_bssgp: use BVCI_SIGNALLING/BVCI_PTM instead of 0/1
......................................................................

gprs_bssgp: use BVCI_SIGNALLING/BVCI_PTM instead of 0/1

Makes more understandable and clear what's meant in the code.

Related: OS#3879
Change-Id: I9d0545fac0af0dcc1783040a376a9b8e65a92699
---
M src/gb/gprs_bssgp.c
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c
index c91abd6..207c9a8 100644
--- a/src/gb/gprs_bssgp.c
+++ b/src/gb/gprs_bssgp.c
@@ -113,10 +113,9 @@
 	OSMO_ASSERT(pdu == BSSGP_PDUT_BVC_RESET || pdu == BSSGP_PDUT_BVC_RESET_ACK);
 
 	msgb_nsei(msg) = nsei;
-	msgb_bvci(msg) = 0; /* Signalling */
+	msgb_bvci(msg) = BVCI_SIGNALLING;
 	bgph->pdu_type = pdu;
 
-
 	msgb_tvlv_put(msg, BSSGP_IE_BVCI, 2, (uint8_t *) &_bvci);
 
 	if (pdu == BSSGP_PDUT_BVC_RESET) {
@@ -388,7 +387,7 @@
 
 	/* When we receive a BVC-RESET PDU (at least of a PTP BVCI), the BSS
 	 * informs us about its RAC + Cell ID, so we can create a mapping */
-	if (bctx->is_sgsn && bvci != 0 && bvci != 1) {
+	if (bctx->is_sgsn && bvci != BVCI_SIGNALLING && bvci != BVCI_PTM) {
 		if (!TLVP_PRES_LEN(tp, BSSGP_IE_CELL_ID, 8)) {
 			LOGP(DLBSSGP, LOGL_ERROR, "BSSGP BVCI=%u Rx RESET "
 				"missing mandatory IE\n", bvci);
@@ -402,7 +401,7 @@
 	}
 
 	/* Acknowledge the RESET to the BTS */
-	if (bvci == 0 || bvci == 1 || bctx->is_sgsn)
+	if (bvci == BVCI_SIGNALLING || bvci == BVCI_PTM || bctx->is_sgsn)
 		bssgp_tx_simple_bvci(BSSGP_PDUT_BVC_RESET_ACK,
 				     nsei, bvci, ns_bvci);
 	else

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23013
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9d0545fac0af0dcc1783040a376a9b8e65a92699
Gerrit-Change-Number: 23013
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210301/92b20f6b/attachment.htm>


More information about the gerrit-log mailing list