<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23013">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_bssgp: use BVCI_SIGNALLING/BVCI_PTM instead of 0/1<br><br>Makes more understandable and clear what's meant in the code.<br><br>Related: OS#3879<br>Change-Id: I9d0545fac0af0dcc1783040a376a9b8e65a92699<br>---<br>M src/gb/gprs_bssgp.c<br>1 file changed, 3 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c</span><br><span>index c91abd6..207c9a8 100644</span><br><span>--- a/src/gb/gprs_bssgp.c</span><br><span>+++ b/src/gb/gprs_bssgp.c</span><br><span>@@ -113,10 +113,9 @@</span><br><span>         OSMO_ASSERT(pdu == BSSGP_PDUT_BVC_RESET || pdu == BSSGP_PDUT_BVC_RESET_ACK);</span><br><span> </span><br><span>     msgb_nsei(msg) = nsei;</span><br><span style="color: hsl(0, 100%, 40%);">-  msgb_bvci(msg) = 0; /* Signalling */</span><br><span style="color: hsl(120, 100%, 40%);">+  msgb_bvci(msg) = BVCI_SIGNALLING;</span><br><span>    bgph->pdu_type = pdu;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>         msgb_tvlv_put(msg, BSSGP_IE_BVCI, 2, (uint8_t *) &_bvci);</span><br><span> </span><br><span>    if (pdu == BSSGP_PDUT_BVC_RESET) {</span><br><span>@@ -388,7 +387,7 @@</span><br><span> </span><br><span>         /* When we receive a BVC-RESET PDU (at least of a PTP BVCI), the BSS</span><br><span>          * informs us about its RAC + Cell ID, so we can create a mapping */</span><br><span style="color: hsl(0, 100%, 40%);">-    if (bctx->is_sgsn && bvci != 0 && bvci != 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+     if (bctx->is_sgsn && bvci != BVCI_SIGNALLING && bvci != BVCI_PTM) {</span><br><span>               if (!TLVP_PRES_LEN(tp, BSSGP_IE_CELL_ID, 8)) {</span><br><span>                       LOGP(DLBSSGP, LOGL_ERROR, "BSSGP BVCI=%u Rx RESET "</span><br><span>                                "missing mandatory IE\n", bvci);</span><br><span>@@ -402,7 +401,7 @@</span><br><span>     }</span><br><span> </span><br><span>        /* Acknowledge the RESET to the BTS */</span><br><span style="color: hsl(0, 100%, 40%);">-  if (bvci == 0 || bvci == 1 || bctx->is_sgsn)</span><br><span style="color: hsl(120, 100%, 40%);">+       if (bvci == BVCI_SIGNALLING || bvci == BVCI_PTM || bctx->is_sgsn)</span><br><span>                 bssgp_tx_simple_bvci(BSSGP_PDUT_BVC_RESET_ACK,</span><br><span>                                    nsei, bvci, ns_bvci);</span><br><span>   else</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23013">change 23013</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23013"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9d0545fac0af0dcc1783040a376a9b8e65a92699 </div>
<div style="display:none"> Gerrit-Change-Number: 23013 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>