Change in osmo-bts[master]: allow to configure multiple oml remote-ip addresses

pespin gerrit-no-reply at lists.osmocom.org
Wed Jun 30 15:28:38 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24513 )

Change subject: allow to configure multiple oml remote-ip addresses
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/24513/6/src/common/abis.c 
File src/common/abis.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24513/6/src/common/abis.c@147 
PS6, Line 147: 	if (!llist_contains(&bts->bsc_oml_hosts, priv->bsc_oml_host))
> I thought that this would solve the problem. […]
what if you remove then add again with a different ip addr? You may end up with a different struct in the same memory region.
Keeping dandling pointers to freed memory is only asking for future problems, I'd avoid it in any case. Even worse if we keep using the dangling pointer pointing to nowehere meaningful like you do here.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24513
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I205f68a3a7f35fee4c38a7cfba2b014237df2727
Gerrit-Change-Number: 24513
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 30 Jun 2021 15:28:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210630/2473ba84/attachment.htm>


More information about the gerrit-log mailing list