Change in osmo-bts[master]: allow to configure multiple oml remote-ip addresses

dexter gerrit-no-reply at lists.osmocom.org
Wed Jun 30 15:20:34 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24513 )

Change subject: allow to configure multiple oml remote-ip addresses
......................................................................


Patch Set 7:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/24513/6/src/common/abis.c 
File src/common/abis.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24513/6/src/common/abis.c@130 
PS6, Line 130: 		osmo_fsm_inst_state_chg(fi, ABIS_LINK_ST_FAILED, 0, 0);
> maybe "ABIS_LINK_ST_CONN_DROPPED" would be more meaningful, since it's actually what happens when yo […]
The state ABIS_LINK_ST_FAILED means that the abis link failed finally. This situation here may be a bit special. We can (probably) not simply go to the next BSC when osmo-bts was running with a different one before. I fear that we will get unpredictable behavior then. So if there was an oml/rsl connection before we can not go back to CONNECTING, we go to FAILURE instead which will initiate a shutdown of omso-bts.


https://gerrit.osmocom.org/c/osmo-bts/+/24513/6/src/common/abis.c@147 
PS6, Line 147: 	if (!llist_contains(&bts->bsc_oml_hosts, priv->bsc_oml_host))
> you are potentially accessing already freed memory here, since priv->bsc_oml_host is a pointer point […]
I thought that this would solve the problem. The function llist_contains() goes through the list and tries to find the pointer priv->bsc_oml_host, if it is not in there it has been removed by the VTY, but then we know and we set priv->bsc_oml_host to NULL then. The function llist_contains() does not de-reference priv->bsc_oml_host, it just uses the address for comparison.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24513
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I205f68a3a7f35fee4c38a7cfba2b014237df2727
Gerrit-Change-Number: 24513
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 30 Jun 2021 15:20:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210630/b58e57ac/attachment.htm>


More information about the gerrit-log mailing list