This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22165 ) Change subject: power_control: omit BS Power Parameters IE if the maximum is 0 dB ...................................................................... power_control: omit BS Power Parameters IE if the maximum is 0 dB If BS Power Parameters IE is present in the channel activation message, the BTS shall employ dynamic BS power control for that logical channel and interpret BS Power IE as the maximum value. If the maximum value is 0 dB, then it does not make sense to send BS Power Parameters IE to the BTS, because the power control loop would never exceed the maximum. Change-Id: If8507992dfd90ade1edda99b72bf2420a702ccd5 Related: SYS#4918, SYS#4919 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 0d92141..809cd9b 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -237,6 +237,12 @@ if (cp->mode != GSM_PWR_CTRL_MODE_DYN_BTS) return; + /* No dynamic BS power control if the maximum is 0 dB */ + if (cp->dir == GSM_PWR_CTRL_DIR_DL) { + if (lchan->bs_power_db == 0) + return; + } + /* Put tag first, length will be updated later */ uint8_t *ie_len = msgb_tl_put(msg, iei); uint8_t msg_len = msgb_length(msg); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If8507992dfd90ade1edda99b72bf2420a702ccd5 Gerrit-Change-Number: 22165 Gerrit-PatchSet: 9 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210630/7d94773a/attachment.htm>