<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22165">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">power_control: omit BS Power Parameters IE if the maximum is 0 dB<br><br>If BS Power Parameters IE is present in the channel activation<br>message, the BTS shall employ dynamic BS power control for that<br>logical channel and interpret BS Power IE as the maximum value.<br><br>If the maximum value is 0 dB, then it does not make sense to send<br>BS Power Parameters IE to the BTS, because the power control loop<br>would never exceed the maximum.<br><br>Change-Id: If8507992dfd90ade1edda99b72bf2420a702ccd5<br>Related: SYS#4918, SYS#4919<br>---<br>M src/osmo-bsc/abis_rsl.c<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c</span><br><span>index 0d92141..809cd9b 100644</span><br><span>--- a/src/osmo-bsc/abis_rsl.c</span><br><span>+++ b/src/osmo-bsc/abis_rsl.c</span><br><span>@@ -237,6 +237,12 @@</span><br><span> if (cp->mode != GSM_PWR_CTRL_MODE_DYN_BTS)</span><br><span> return;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* No dynamic BS power control if the maximum is 0 dB */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (cp->dir == GSM_PWR_CTRL_DIR_DL) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (lchan->bs_power_db == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Put tag first, length will be updated later */</span><br><span> uint8_t *ie_len = msgb_tl_put(msg, iei);</span><br><span> uint8_t msg_len = msgb_length(msg);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22165">change 22165</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/22165"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If8507992dfd90ade1edda99b72bf2420a702ccd5 </div>
<div style="display:none"> Gerrit-Change-Number: 22165 </div>
<div style="display:none"> Gerrit-PatchSet: 9 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>