Change in libosmo-sccp[master]: osmo_ss7_vty: allow users to inspect routes also in ASP role

laforge gerrit-no-reply at lists.osmocom.org
Wed Jun 30 08:14:07 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/24705 )

Change subject: osmo_ss7_vty: allow users to inspect routes also in ASP role
......................................................................

osmo_ss7_vty: allow users to inspect routes also in ASP role

When libosmo-sigtran runs in ASP role, then the entire routing table
introspection (show) and routing table configuration VTY commands are
not present. Editing the routing table manually only makes sense in SG
role, but it is still useful to be able to inspect the routing table in
ASP and SG mode.

Change-Id: Ieaef4f0344b5b77ff5047013e9da1e938004e97c
Related: SYS#5392
---
M src/osmo_ss7_vty.c
M tests/vty/ss7_asp_test.vty
2 files changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c
index bd15070..3b39a61 100644
--- a/src/osmo_ss7_vty.c
+++ b/src/osmo_ss7_vty.c
@@ -2159,6 +2159,8 @@
 	install_lib_element(L_CS7_AS_NODE, &as_pc_override_cmd);
 	install_lib_element(L_CS7_AS_NODE, &as_pc_patch_sccp_cmd);
 
+	install_lib_element_ve(&show_cs7_route_cmd);
+
 	vty_init_addr();
 }
 
@@ -2174,7 +2176,6 @@
 	vty_init_shared(ctx);
 
 	install_node(&rtable_node, NULL);
-	install_lib_element_ve(&show_cs7_route_cmd);
 	install_lib_element(L_CS7_NODE, &cs7_route_table_cmd);
 	install_lib_element(L_CS7_RTABLE_NODE, &cfg_description_cmd);
 	install_lib_element(L_CS7_RTABLE_NODE, &cs7_rt_upd_cmd);
diff --git a/tests/vty/ss7_asp_test.vty b/tests/vty/ss7_asp_test.vty
index fd54642..bfbb77e 100644
--- a/tests/vty/ss7_asp_test.vty
+++ b/tests/vty/ss7_asp_test.vty
@@ -5,6 +5,7 @@
   show cs7 config
   show cs7 instance <0-15> asp
   show cs7 instance <0-15> as (active|all|m3ua|sua)
+  show cs7 instance <0-15> route
   show cs7 instance <0-15> sccp addressbook
   show cs7 instance <0-15> sccp users
   show cs7 instance <0-15> sccp ssn <0-65535>
@@ -20,6 +21,7 @@
   show cs7 config
   show cs7 instance <0-15> asp
   show cs7 instance <0-15> as (active|all|m3ua|sua)
+  show cs7 instance <0-15> route
   show cs7 instance <0-15> sccp addressbook
   show cs7 instance <0-15> sccp users
   show cs7 instance <0-15> sccp ssn <0-65535>
@@ -49,6 +51,7 @@
   users  User Table
   asp    Application Server Process (ASP)
   as     Application Server (AS)
+  route  Routing Table
   sccp   Signalling Connection Control Part
 
 ss7_asp_vty_test# show cs7 instance 0 as ?

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/24705
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ieaef4f0344b5b77ff5047013e9da1e938004e97c
Gerrit-Change-Number: 24705
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210630/65477e59/attachment.htm>


More information about the gerrit-log mailing list