<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/24705">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo_ss7_vty: allow users to inspect routes also in ASP role<br><br>When libosmo-sigtran runs in ASP role, then the entire routing table<br>introspection (show) and routing table configuration VTY commands are<br>not present. Editing the routing table manually only makes sense in SG<br>role, but it is still useful to be able to inspect the routing table in<br>ASP and SG mode.<br><br>Change-Id: Ieaef4f0344b5b77ff5047013e9da1e938004e97c<br>Related: SYS#5392<br>---<br>M src/osmo_ss7_vty.c<br>M tests/vty/ss7_asp_test.vty<br>2 files changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c</span><br><span>index bd15070..3b39a61 100644</span><br><span>--- a/src/osmo_ss7_vty.c</span><br><span>+++ b/src/osmo_ss7_vty.c</span><br><span>@@ -2159,6 +2159,8 @@</span><br><span>    install_lib_element(L_CS7_AS_NODE, &as_pc_override_cmd);</span><br><span>         install_lib_element(L_CS7_AS_NODE, &as_pc_patch_sccp_cmd);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    install_lib_element_ve(&show_cs7_route_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   vty_init_addr();</span><br><span> }</span><br><span> </span><br><span>@@ -2174,7 +2176,6 @@</span><br><span>    vty_init_shared(ctx);</span><br><span> </span><br><span>    install_node(&rtable_node, NULL);</span><br><span style="color: hsl(0, 100%, 40%);">-   install_lib_element_ve(&show_cs7_route_cmd);</span><br><span>     install_lib_element(L_CS7_NODE, &cs7_route_table_cmd);</span><br><span>   install_lib_element(L_CS7_RTABLE_NODE, &cfg_description_cmd);</span><br><span>    install_lib_element(L_CS7_RTABLE_NODE, &cs7_rt_upd_cmd);</span><br><span>diff --git a/tests/vty/ss7_asp_test.vty b/tests/vty/ss7_asp_test.vty</span><br><span>index fd54642..bfbb77e 100644</span><br><span>--- a/tests/vty/ss7_asp_test.vty</span><br><span>+++ b/tests/vty/ss7_asp_test.vty</span><br><span>@@ -5,6 +5,7 @@</span><br><span>   show cs7 config</span><br><span>   show cs7 instance <0-15> asp</span><br><span>   show cs7 instance <0-15> as (active|all|m3ua|sua)</span><br><span style="color: hsl(120, 100%, 40%);">+  show cs7 instance <0-15> route</span><br><span>   show cs7 instance <0-15> sccp addressbook</span><br><span>   show cs7 instance <0-15> sccp users</span><br><span>   show cs7 instance <0-15> sccp ssn <0-65535></span><br><span>@@ -20,6 +21,7 @@</span><br><span>   show cs7 config</span><br><span>   show cs7 instance <0-15> asp</span><br><span>   show cs7 instance <0-15> as (active|all|m3ua|sua)</span><br><span style="color: hsl(120, 100%, 40%);">+  show cs7 instance <0-15> route</span><br><span>   show cs7 instance <0-15> sccp addressbook</span><br><span>   show cs7 instance <0-15> sccp users</span><br><span>   show cs7 instance <0-15> sccp ssn <0-65535></span><br><span>@@ -49,6 +51,7 @@</span><br><span>   users  User Table</span><br><span>   asp    Application Server Process (ASP)</span><br><span>   as     Application Server (AS)</span><br><span style="color: hsl(120, 100%, 40%);">+  route  Routing Table</span><br><span>   sccp   Signalling Connection Control Part</span><br><span> </span><br><span> ss7_asp_vty_test# show cs7 instance 0 as ?</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/24705">change 24705</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/24705"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ieaef4f0344b5b77ff5047013e9da1e938004e97c </div>
<div style="display:none"> Gerrit-Change-Number: 24705 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>