Change in osmo-bts[master]: allow to configure multiple oml remote-ip addresses

pespin gerrit-no-reply at
Mon Jun 28 15:35:30 UTC 2021

pespin has posted comments on this change. ( )

Change subject: allow to configure multiple oml remote-ip addresses

Patch Set 5:

File src/common/abis.c: 
CONN means CONNECTED here? CONNECTING? Most probably needs to be changed to some of those, it's not clear at first sight. 
state is FAILED right? FAIL it's more like an event or action. 
PS5, Line 87: static void abis_link_conn_action(struct osmo_fsm_inst *fi, uint32_t event, void *data)
we usually don't use "_action" suffix, only the name. Changing state name to something more meaningful may help here. 
PS5, Line 144: 		/* In some implementations the user may specify a BSC host via commandline switch. If this is the case
(doesn't look clear to me to take cmdline related specialties here, but OK) 
PS5, Line 148: 	} else if ((struct llist_head *)priv->bsc_oml_host != (struct llist_head *)&bts-> {
llist_first(&bts->bsc_oml_hosts)? Or do you actually mean the end of the list? isn't that "previous"? 
PS5, Line 149: 		/* Get a BSC host from the list and move the list heade one position forward. */
type: header 
PS5, Line 153: 	} else {
maybe moving this early termiantion above (if condition) would help making the function a bit less complex 
PS5, Line 163: 	osmo_get_macaddr(bts_dev_info.mac_addr, "eth0");
what is this? hardcoded eth0? this looks wrong 
PS5, Line 172: 	if (line) {
drop {} 
PS5, Line 176: 	priv->line_ctr++;
not sure what this is about 
PS5, Line 206: 			       .name = "CONN",
PS5, Line 207: 			       .in_event_mask = 0 | S(ABIS_LINK_EV_SIGN_LINK_DOWN)
this 0| can be dropped 
File src/common/main.c: 
PS5, Line 399: 	if (llist_count(&g_bts->bsc_oml_hosts) == 0) {
what about the cmdline oml ip I saw in the fsm which was outisde the llist? 
File src/common/vty.c: 
PS5, Line 536: {
iirc you are maintaining a pointer to the currently "connecting" remote ip. If you remove it through this VTY cmd, when the conn fails it will try to access the already freed pointer.

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I205f68a3a7f35fee4c38a7cfba2b014237df2727
Gerrit-Change-Number: 24513
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at>
Gerrit-CC: fixeria <vyanitskiy at>
Gerrit-CC: pespin <pespin at>
Gerrit-Comment-Date: Mon, 28 Jun 2021 15:35:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list