Change in osmo-bts[master]: allow to configure multiple oml remote-ip addresses

laforge gerrit-no-reply at
Mon Jun 28 15:25:33 UTC 2021

laforge has posted comments on this change. ( )

Change subject: allow to configure multiple oml remote-ip addresses

Patch Set 5:

File src/common/abis.c: 
PS5, Line 65: W
from these names it's not entirely clear to me what the states represent.  "CONN" is probably actively connected. "DOWN" or "FAIL" sound a bit confusing and I would think that at least one of them sounds more like an event than a state? I'll see below if I can find out... 
PS5, Line 206: 	       .
some strange space-based indenting here, at least it looks like that in gerrit 
PS5, Line 207: 			       .in_event_mask = 0 | S(ABIS_LINK_EV_SIGN_LINK_DOWN)
please drop the "0 |". It doesn't add any functionality (the default behavior is the same), and I have not seen this anywhere else in our code. 
PS5, Line 216: 			       .in_event_mask = 0,
how does this work?  A FSM state "DOWN" which does not permit any input events, but which has multiple exit states?

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I205f68a3a7f35fee4c38a7cfba2b014237df2727
Gerrit-Change-Number: 24513
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at>
Gerrit-CC: fixeria <vyanitskiy at>
Gerrit-CC: pespin <pespin at>
Gerrit-Comment-Date: Mon, 28 Jun 2021 15:25:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list