Change in osmo-bsc[master]: power_control: implement BCCH carrier power reduction operation

fixeria gerrit-no-reply at lists.osmocom.org
Mon Jun 28 11:34:38 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24777 )

Change subject: power_control: implement BCCH carrier power reduction operation
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24777/1/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24777/1/src/osmo-bsc/bsc_vty.c@6025 
PS1, Line 6025:       "bts <0-255> bcch-power-red <0-6>",
> this is an interactive command, and not something part of the 'configure' node. […]
This is not a configuration command, and it is intentional to have it in the ENABLE_NODE. Similar to 'resend-power-control-defaults' and 'resend-system-information', this command does not affect the internal BSC's structures and simply triggers sending of an A-bis/RSL message to a BTS. I don't know why would we want to have it in the BTS_NODE?

My initial idea was to implement a CTRL interface command for managing the BCCH carrier power reduction mode. This seemed to be logical, but then I would need to define both GET and SET commands. For that, I would need to store the actual 'bcch-power-red' somewhere and ensure that it holds a valid value even if the BTS restarts. So I gave up and decided to add a VTY command.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24777
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I047fce33d4d3e4c569dd006ba17858467a2f4783
Gerrit-Change-Number: 24777
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Jun 2021 11:34:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210628/48f86e1c/attachment.htm>


More information about the gerrit-log mailing list