Change in osmo-bsc[master]: power_control: implement BCCH carrier power reduction operation

laforge gerrit-no-reply at lists.osmocom.org
Mon Jun 28 08:44:17 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24777 )

Change subject: power_control: implement BCCH carrier power reduction operation
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/24777/1/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24777/1/src/osmo-bsc/bsc_vty.c@6025 
PS1, Line 6025:       "bts <0-255> bcch-power-red <0-6>",
> I wonder why isn't this in the BTS_NODE?
this is an interactive command, and not something part of the 'configure' node.  Not sure if that is intentional.  At the very least we should have a 'configure' command, while this one for interactive use is only useful for R&D and testing, right?


https://gerrit.osmocom.org/c/osmo-bsc/+/24777/1/src/osmo-bsc/bts_osmobts.c 
File src/osmo-bsc/bts_osmobts.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24777/1/src/osmo-bsc/bts_osmobts.c@71 
PS1, Line 71: 	return abis_rsl_sendmsg(msg);
> So AFAIU using the VTY command immediately sends an RSL message? what if the config is read at start […]
the existing VTY command is not a 'configure' command!



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24777
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I047fce33d4d3e4c569dd006ba17858467a2f4783
Gerrit-Change-Number: 24777
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Jun 2021 08:44:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210628/3c9872e2/attachment.htm>


More information about the gerrit-log mailing list