This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24722 ) Change subject: add Kc128 to gsm0808 Create Ciphering Command ...................................................................... Patch Set 3: Code-Review+2 (1 comment) (combine votes) https://gerrit.osmocom.org/c/libosmocore/+/24722/3/include/osmocom/gsm/gsm0808.h File include/osmocom/gsm/gsm0808.h: https://gerrit.osmocom.org/c/libosmocore/+/24722/3/include/osmocom/gsm/gsm0808.h@73 PS3, Line 73: bool more_items; /*< always set this to false */ > I agree with Pau here. […] so far i was only aware of the 'more_items' method. using sizeof() is interesting, could have done that. but in this file the 'more_items' way is already in use in many places, so i guess i'll stick to that for gsm0808.h -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24722 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib3906085e0c6e5a496a9f755f0f786238a86ca34 Gerrit-Change-Number: 24722 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 23 Jun 2021 17:23:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210623/e1cfb07c/attachment.htm>