Change in libosmocore[master]: add Kc128 to gsm0808 Create Ciphering Command

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jun 23 16:05:53 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24722 )

Change subject: add Kc128 to gsm0808 Create Ciphering Command
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/24722/3/include/osmocom/gsm/gsm0808.h 
File include/osmocom/gsm/gsm0808.h:

https://gerrit.osmocom.org/c/libosmocore/+/24722/3/include/osmocom/gsm/gsm0808.h@73 
PS3, Line 73: 	bool more_items; /*< always set this to false */
> FYI, in case you envision to have several versions of the struct, a usual way (see for instance Wind […]
I agree with Pau here. Having one 'special' field containing the size seems to be better than adding more_items2, more_items3, etc. every time we need to extend this structure. But with this approach it's kind of easier to assume which fields are present and which are not.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24722
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib3906085e0c6e5a496a9f755f0f786238a86ca34
Gerrit-Change-Number: 24722
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 23 Jun 2021 16:05:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210623/b146f09c/attachment.htm>


More information about the gerrit-log mailing list