Change in osmo-bts[master]: scheduler: fix wrong union field in trx_sched_tch_req()

fixeria gerrit-no-reply at lists.osmocom.org
Tue Jun 22 17:04:38 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/24745 )


Change subject: scheduler: fix wrong union field in trx_sched_tch_req()
......................................................................

scheduler: fix wrong union field in trx_sched_tch_req()

I introduced this regression in [1] during a massive refactoring.
Basically, I copy-pasted a chunk from trx_sched_ph_data_req(), but
forgot to change the union field.  This broke voice calls, because
all TCH.req primitives would be enqueued to wrong timeslot.

Change-Id: If841e6ac40a3c6344c304ab970755d6a2d292156
Fixes: [1] I7c4379e43a25e9d858d582a99bf6c4b65c9af481
---
M src/common/scheduler.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/45/24745/1

diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index 3dd7693..ea4aee4 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -868,7 +868,7 @@
 
 int trx_sched_tch_req(struct gsm_bts_trx *trx, struct osmo_phsap_prim *l1sap)
 {
-	uint8_t tn = L1SAP_CHAN2TS(l1sap->u.data.chan_nr);
+	uint8_t tn = L1SAP_CHAN2TS(l1sap->u.tch.chan_nr);
 	struct l1sched_ts *l1ts = trx->ts[tn].priv;
 
 	LOGL1S(DL1P, LOGL_DEBUG, l1ts, -1, l1sap->u.tch.fn,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24745
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If841e6ac40a3c6344c304ab970755d6a2d292156
Gerrit-Change-Number: 24745
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210622/f2cd402e/attachment.htm>


More information about the gerrit-log mailing list