<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24745">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">scheduler: fix wrong union field in trx_sched_tch_req()<br><br>I introduced this regression in [1] during a massive refactoring.<br>Basically, I copy-pasted a chunk from trx_sched_ph_data_req(), but<br>forgot to change the union field.  This broke voice calls, because<br>all TCH.req primitives would be enqueued to wrong timeslot.<br><br>Change-Id: If841e6ac40a3c6344c304ab970755d6a2d292156<br>Fixes: [1] I7c4379e43a25e9d858d582a99bf6c4b65c9af481<br>---<br>M src/common/scheduler.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/45/24745/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/scheduler.c b/src/common/scheduler.c</span><br><span>index 3dd7693..ea4aee4 100644</span><br><span>--- a/src/common/scheduler.c</span><br><span>+++ b/src/common/scheduler.c</span><br><span>@@ -868,7 +868,7 @@</span><br><span> </span><br><span> int trx_sched_tch_req(struct gsm_bts_trx *trx, struct osmo_phsap_prim *l1sap)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-   uint8_t tn = L1SAP_CHAN2TS(l1sap->u.data.chan_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t tn = L1SAP_CHAN2TS(l1sap->u.tch.chan_nr);</span><br><span>         struct l1sched_ts *l1ts = trx->ts[tn].priv;</span><br><span> </span><br><span>   LOGL1S(DL1P, LOGL_DEBUG, l1ts, -1, l1sap->u.tch.fn,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/24745">change 24745</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/24745"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If841e6ac40a3c6344c304ab970755d6a2d292156 </div>
<div style="display:none"> Gerrit-Change-Number: 24745 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>