Change in osmo-bts[master]: main: do not use fprintf to log fatal errors

laforge gerrit-no-reply at lists.osmocom.org
Fri Jun 18 12:33:32 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24707 )

Change subject: main: do not use fprintf to log fatal errors
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/24707/1/src/common/main.c 
File src/common/main.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24707/1/src/common/main.c@95 
PS1, Line 95: 			LOGP(DLGLOBAL, LOGL_FATAL, "%s: Unknown VTY reference generation "
> You shouldn't use libosmocore logging system here, because you are still configuring it from cmd lin […]
I agree, we cannot use logging here.


https://gerrit.osmocom.org/c/osmo-bts/+/24707/1/src/common/main.c@306 
PS1, Line 306: 		LOGP(DLGLOBAL, LOGL_FATAL, "Failed to create BTS structure\n");
> I'm not sure whether it's a 100% good idea to merge this patch, specially since we introduced suppor […]
what is more realistic in production deployments is e.g. the use of syslog target. and I'd say that's important.

We possibly could introduce some logic to libosmocore that would not do async writes but only sync writes until osmo_select_main() is called the first time?  This way it would be safe and do the right thing in all cases.


https://gerrit.osmocom.org/c/osmo-bts/+/24707/1/src/common/main.c@420 
PS1, Line 420: 			perror("Error during daemonize");
> If all lines are changed, this perror() line should too.
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24707
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I2ae4acf6a92137236e1b62c2d0aab79a34134f45
Gerrit-Change-Number: 24707
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Jun 2021 12:33:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210618/5c82a5fc/attachment.htm>


More information about the gerrit-log mailing list