Change in osmo-bts[master]: osmo-bts-{trx, virtual}: get rid of dummy tx_idle_fn()

fixeria gerrit-no-reply at lists.osmocom.org
Thu Jun 17 22:34:12 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/24711 )


Change subject: osmo-bts-{trx,virtual}: get rid of dummy tx_idle_fn()
......................................................................

osmo-bts-{trx,virtual}: get rid of dummy tx_idle_fn()

This logical channel handler does nothing more than just logging.

Change-Id: I438705f8dd902193e6c7b499d8ee55c56b6a1c2e
---
M include/osmo-bts/scheduler_backend.h
M src/common/scheduler.c
M src/osmo-bts-trx/scheduler_trx.c
M src/osmo-bts-virtual/scheduler_virtbts.c
4 files changed, 0 insertions(+), 15 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/11/24711/1

diff --git a/include/osmo-bts/scheduler_backend.h b/include/osmo-bts/scheduler_backend.h
index c54591e..50ba822 100644
--- a/include/osmo-bts/scheduler_backend.h
+++ b/include/osmo-bts/scheduler_backend.h
@@ -53,7 +53,6 @@
 			   int16_t ta_offs_256bits, uint16_t ber10k, float rssi,
 			   uint8_t is_sub);
 
-int tx_idle_fn(struct l1sched_ts *l1ts, struct trx_dl_burst_req *br);
 int tx_fcch_fn(struct l1sched_ts *l1ts, struct trx_dl_burst_req *br);
 int tx_sch_fn(struct l1sched_ts *l1ts, struct trx_dl_burst_req *br);
 int tx_data_fn(struct l1sched_ts *l1ts, struct trx_dl_burst_req *br);
diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index a010b39..b4f2fa8 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -148,7 +148,6 @@
 		/* On C0, BTS needs to ensure discontinuous burst transmission.
 		 * Therefore we need to send dummy bursts on IDLE slots. */
 		.flags = TRX_CHAN_FLAG_AUTO_ACTIVE,
-		.dl_fn = tx_idle_fn,
 	},
 	[TRXC_FCCH] = {
 		.name = "FCCH", /* 3GPP TS 05.02, section 3.3.2.1 */
diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c
index 0a2052c..97c5ff3 100644
--- a/src/osmo-bts-trx/scheduler_trx.c
+++ b/src/osmo-bts-trx/scheduler_trx.c
@@ -53,13 +53,6 @@
 #define SCHED_FH_PARAMS_VALS(ts) \
 	(ts)->hopping.hsn, (ts)->hopping.maio, (ts)->hopping.arfcn_num
 
-/* an IDLE burst returns nothing. on C0 it is replaced by dummy burst */
-int tx_idle_fn(struct l1sched_ts *l1ts, struct trx_dl_burst_req *br)
-{
-	LOGL1SB(DL1P, LOGL_DEBUG, l1ts, br, "Transmitting IDLE\n");
-	return 0;
-}
-
 static void ts_report_interf_meas(const struct gsm_bts_trx_ts *ts)
 {
 	const struct l1sched_ts *l1ts = ts->priv;
diff --git a/src/osmo-bts-virtual/scheduler_virtbts.c b/src/osmo-bts-virtual/scheduler_virtbts.c
index 4beb966..9d2adfc 100644
--- a/src/osmo-bts-virtual/scheduler_virtbts.c
+++ b/src/osmo-bts-virtual/scheduler_virtbts.c
@@ -177,12 +177,6 @@
  * TX on downlink
  */
 
-/* an IDLE burst returns nothing. on C0 it is replaced by dummy burst */
-int tx_idle_fn(struct l1sched_ts *l1ts, struct trx_dl_burst_req *br)
-{
-	return 0;
-}
-
 int tx_fcch_fn(struct l1sched_ts *l1ts, struct trx_dl_burst_req *br)
 {
 	return 0;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24711
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I438705f8dd902193e6c7b499d8ee55c56b6a1c2e
Gerrit-Change-Number: 24711
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210617/15ddffc6/attachment.htm>


More information about the gerrit-log mailing list