<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/24711">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-bts-{trx,virtual}: get rid of dummy tx_idle_fn()<br><br>This logical channel handler does nothing more than just logging.<br><br>Change-Id: I438705f8dd902193e6c7b499d8ee55c56b6a1c2e<br>---<br>M include/osmo-bts/scheduler_backend.h<br>M src/common/scheduler.c<br>M src/osmo-bts-trx/scheduler_trx.c<br>M src/osmo-bts-virtual/scheduler_virtbts.c<br>4 files changed, 0 insertions(+), 15 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/11/24711/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmo-bts/scheduler_backend.h b/include/osmo-bts/scheduler_backend.h</span><br><span>index c54591e..50ba822 100644</span><br><span>--- a/include/osmo-bts/scheduler_backend.h</span><br><span>+++ b/include/osmo-bts/scheduler_backend.h</span><br><span>@@ -53,7 +53,6 @@</span><br><span>                        int16_t ta_offs_256bits, uint16_t ber10k, float rssi,</span><br><span>                        uint8_t is_sub);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-int tx_idle_fn(struct l1sched_ts *l1ts, struct trx_dl_burst_req *br);</span><br><span> int tx_fcch_fn(struct l1sched_ts *l1ts, struct trx_dl_burst_req *br);</span><br><span> int tx_sch_fn(struct l1sched_ts *l1ts, struct trx_dl_burst_req *br);</span><br><span> int tx_data_fn(struct l1sched_ts *l1ts, struct trx_dl_burst_req *br);</span><br><span>diff --git a/src/common/scheduler.c b/src/common/scheduler.c</span><br><span>index a010b39..b4f2fa8 100644</span><br><span>--- a/src/common/scheduler.c</span><br><span>+++ b/src/common/scheduler.c</span><br><span>@@ -148,7 +148,6 @@</span><br><span>            /* On C0, BTS needs to ensure discontinuous burst transmission.</span><br><span>               * Therefore we need to send dummy bursts on IDLE slots. */</span><br><span>          .flags = TRX_CHAN_FLAG_AUTO_ACTIVE,</span><br><span style="color: hsl(0, 100%, 40%);">-             .dl_fn = tx_idle_fn,</span><br><span>         },</span><br><span>   [TRXC_FCCH] = {</span><br><span>              .name = "FCCH", /* 3GPP TS 05.02, section 3.3.2.1 */</span><br><span>diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c</span><br><span>index 0a2052c..97c5ff3 100644</span><br><span>--- a/src/osmo-bts-trx/scheduler_trx.c</span><br><span>+++ b/src/osmo-bts-trx/scheduler_trx.c</span><br><span>@@ -53,13 +53,6 @@</span><br><span> #define SCHED_FH_PARAMS_VALS(ts) \</span><br><span>       (ts)->hopping.hsn, (ts)->hopping.maio, (ts)->hopping.arfcn_num</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* an IDLE burst returns nothing. on C0 it is replaced by dummy burst */</span><br><span style="color: hsl(0, 100%, 40%);">-int tx_idle_fn(struct l1sched_ts *l1ts, struct trx_dl_burst_req *br)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">-        LOGL1SB(DL1P, LOGL_DEBUG, l1ts, br, "Transmitting IDLE\n");</span><br><span style="color: hsl(0, 100%, 40%);">-   return 0;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> static void ts_report_interf_meas(const struct gsm_bts_trx_ts *ts)</span><br><span> {</span><br><span>        const struct l1sched_ts *l1ts = ts->priv;</span><br><span>diff --git a/src/osmo-bts-virtual/scheduler_virtbts.c b/src/osmo-bts-virtual/scheduler_virtbts.c</span><br><span>index 4beb966..9d2adfc 100644</span><br><span>--- a/src/osmo-bts-virtual/scheduler_virtbts.c</span><br><span>+++ b/src/osmo-bts-virtual/scheduler_virtbts.c</span><br><span>@@ -177,12 +177,6 @@</span><br><span>  * TX on downlink</span><br><span>  */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* an IDLE burst returns nothing. on C0 it is replaced by dummy burst */</span><br><span style="color: hsl(0, 100%, 40%);">-int tx_idle_fn(struct l1sched_ts *l1ts, struct trx_dl_burst_req *br)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">-   return 0;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> int tx_fcch_fn(struct l1sched_ts *l1ts, struct trx_dl_burst_req *br)</span><br><span> {</span><br><span>      return 0;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/24711">change 24711</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/24711"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I438705f8dd902193e6c7b499d8ee55c56b6a1c2e </div>
<div style="display:none"> Gerrit-Change-Number: 24711 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>