Change in libosmo-abis[master]: ipa: add optional connect timeout to ipa_client_conn_open

pespin gerrit-no-reply at lists.osmocom.org
Thu Jun 17 11:39:05 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/24514 )

Change subject: ipa: add optional connect timeout to ipa_client_conn_open
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmo-abis/+/24514/1/src/input/ipa.c 
File src/input/ipa.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/24514/1/src/input/ipa.c@247 
PS1, Line 247: 		ret = osmo_sock_wait(link->ofd->fd, timeout_msec);
> You have to check I205f68a3a7f35fee4c38a7cfba2b014237df2727 (osmo-bts). […]
I'm not going to block this, but I still have the feeling this is being solved in a strange way. Why are you checking all this asynchronously over fd callbacks? If error_cb or whatever triggers, simply retry connecting with next address?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/24514
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I7bc4345876e3c20266985270d0ddfa770437a053
Gerrit-Change-Number: 24514
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Jun 2021 11:39:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210617/e77dbb57/attachment.htm>


More information about the gerrit-log mailing list