Change in libosmo-abis[master]: ipa: add optional connect timeout to ipa_client_conn_open

dexter gerrit-no-reply at lists.osmocom.org
Thu Jun 17 10:42:23 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/24514 )

Change subject: ipa: add optional connect timeout to ipa_client_conn_open
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/libosmo-abis/+/24514/1/src/input/ipa.c 
File src/input/ipa.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/24514/1/src/input/ipa.c@233 
PS1, Line 233: 
> He's just adding a new line here because he's adding new blocks to the function, so that different s […]
Done


https://gerrit.osmocom.org/c/libosmo-abis/+/24514/1/src/input/ipa.c@247 
PS1, Line 247: 		ret = osmo_sock_wait(link->ofd->fd, timeout_msec);
> So this is the use case you were saying it's fine blocking? Inside a library function? Doesn't look  […]
You have to check I205f68a3a7f35fee4c38a7cfba2b014237df2727 (osmo-bts). It depends how the library is used. timeout_msec is optional. If it is 0, then there is no blocking at all. If the user wants to block in order to make sure that the TCP connection towards the bsc is working before moving on, then timeout_msec can be set to a reasonable value.

In osmo-bts we have this case where the abis connection is made before the main loop is entered and there it makes sense to try all possible BSCs until one is found that is up.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/24514
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I7bc4345876e3c20266985270d0ddfa770437a053
Gerrit-Change-Number: 24514
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Jun 2021 10:42:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210617/c9a7d234/attachment.htm>


More information about the gerrit-log mailing list