Change in osmo-gsm-tester[master]: iperf: adds the option to define the packet length for udp.

pespin gerrit-no-reply at lists.osmocom.org
Thu Jun 10 18:34:50 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24273 )

Change subject: iperf: adds the option to define the packet length for udp.
......................................................................


Patch Set 2:

(1 comment)

Please reword attribute from "length" to "packet_length", imho length is too generic and if we add more params later it may become confusing.
Other than that looks good to me, please rename and I'll merge.

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24273/2/sysmocom/defaults.conf 
File sysmocom/defaults.conf:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24273/2/sysmocom/defaults.conf@206 
PS2, Line 206:   length: 1460
since a default value is not needed, I'd drop it from here, to simplify stuff



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24273
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ic886faa82b7cb25f2bce685eb80910623e4ff686
Gerrit-Change-Number: 24273
Gerrit-PatchSet: 2
Gerrit-Owner: alealcon <alejandro.leal at srs.io>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Jun 2021 18:34:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210610/59768769/attachment.htm>


More information about the gerrit-log mailing list