<p style="white-space: pre-wrap; word-wrap: break-word;">Please reword attribute from "length" to "packet_length", imho length is too generic and if we add more params later it may become confusing.<br>Other than that looks good to me, please rename and I'll merge.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24273">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24273/2/sysmocom/defaults.conf">File sysmocom/defaults.conf:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24273/2/sysmocom/defaults.conf@206">Patch Set #2, Line 206:</a> <code style="font-family:monospace,monospace">  length: 1460</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">since a default value is not needed, I'd drop it from here, to simplify stuff</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24273">change 24273</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24273"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic886faa82b7cb25f2bce685eb80910623e4ff686 </div>
<div style="display:none"> Gerrit-Change-Number: 24273 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: alealcon <alejandro.leal@srs.io> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 10 Jun 2021 18:34:50 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>