Change in osmo-gsm-tester[master]: ms-srs: change the cpu governor before launching the ms.

pespin gerrit-no-reply at lists.osmocom.org
Tue Jun 8 16:12:51 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24270 )

Change subject: ms-srs: change the cpu governor before launching the ms.
......................................................................


Patch Set 1:

As discussed, I see several issues with this approach or some stuff which needs to be clarified:

* Having this done per object may end up creating unexpected results (one object on one test stopping while the other one is running, may turn off the cpu_governor).

* Is this specific to specific target hosts, like the BBU? If that's the case, I guess you can assume the hardware (hence the resource) is going to be used at most by 1 OGT instance/test at a time, and hence I'd move the code to be in the so called "BBU" class running special stuff to configure it, to not pollute srsue code by default.

Does that make sense to you? What do you think?


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24270
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I86ec4fbba8a965e60103b30e2aa60cd2c3f348c9
Gerrit-Change-Number: 24270
Gerrit-PatchSet: 1
Gerrit-Owner: alealcon <alejandro.leal at srs.io>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Jun 2021 16:12:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210608/2b57b592/attachment.htm>


More information about the gerrit-log mailing list