This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24592 ) Change subject: [VAMOS] trx_sched_init_ts(): assign names to per-timeslot counters ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/24592/2/src/common/scheduler.c File src/common/scheduler.c: https://gerrit.osmocom.org/c/osmo-bts/+/24592/2/src/common/scheduler.c@625 PS2, Line 625: osmo_talloc_replace_string_fmt(l1ts->ctrs, &l1ts->ctrs->name, > isn't there an API to set the field? There is rate_ctr_group_set_name() which accepts a constant string. I need a format string. That's why I introduced rate_ctr_group_set_name_fmt(). Then I was recommended to introduce a generic function for that, and this is what I did. > Why aren't you simply using talloc_snprintf or alike and passing it to the proper API? Again, because your API _duplicates_ the given string using talloc_strdup(), so I would need to allocate a string, pass it to rate_ctr_group_set_name() and then free() it. This looks ugly to me. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie872ab37661fa5d44f219f59c7daaa1033113289 Gerrit-Change-Number: 24592 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 07 Jun 2021 14:59:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210607/8e0756f1/attachment.htm>