Change in osmo-bts[master]: [VAMOS] trx_sched_init_ts(): assign names to per-timeslot counters

pespin gerrit-no-reply at lists.osmocom.org
Mon Jun 7 14:50:46 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24592 )

Change subject: [VAMOS] trx_sched_init_ts(): assign names to per-timeslot counters
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/24592/2/src/common/scheduler.c 
File src/common/scheduler.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24592/2/src/common/scheduler.c@625 
PS2, Line 625: 	osmo_talloc_replace_string_fmt(l1ts->ctrs, &l1ts->ctrs->name,
isn't there an API to set the field? Why aren't you simply using talloc_snprintf or alike and passing it to the proper API?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24592
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie872ab37661fa5d44f219f59c7daaa1033113289
Gerrit-Change-Number: 24592
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Jun 2021 14:50:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210607/f173661c/attachment.htm>


More information about the gerrit-log mailing list