Change in libosmocore[master]: osmo_select_shutdown_request(): allow finishing pending writes on SIG...

neels gerrit-no-reply at lists.osmocom.org
Sat Jun 5 21:27:28 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24544 )

Change subject: osmo_select_shutdown_request(): allow finishing pending writes on SIGTERM
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/24544/3/include/osmocom/core/select.h 
File include/osmocom/core/select.h:

https://gerrit.osmocom.org/c/libosmocore/+/24544/3/include/osmocom/core/select.h@108 
PS3, Line 108: void osmo_select_shutdown_request();
and now i'm thinking maybe keep it more generic, setting read/write modes?
like

 lib load default:  osmo_select_mode_set(OSMO_FD_MASK);

  signal_handler(){
      /* set osmo_select_* in write-only mode */
      osmo_select_mode_set(OSMO_FD_WRITE);
  }

  main() {
    while ((osmo_select_mode_get() & OSMO_FD_READ)
           || (osmo_select_pending() & OSMO_FD_WRITE))
       osmo_select_main_ctx(0);
  }

This idea is a bit more generic, but also a bit more complex to implement.
I guess it's feature creep and this current patch set is fine?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24544
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib94d4316924103459577087c2214188679db2227
Gerrit-Change-Number: 24544
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sat, 05 Jun 2021 21:27:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210605/ca44103e/attachment.htm>


More information about the gerrit-log mailing list