<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/24544">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/24544/3/include/osmocom/core/select.h">File include/osmocom/core/select.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/24544/3/include/osmocom/core/select.h@108">Patch Set #3, Line 108:</a> <code style="font-family:monospace,monospace">void osmo_select_shutdown_request();</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">and now i'm thinking maybe keep it more generic, setting read/write modes?<br>like</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> lib load default:  osmo_select_mode_set(OSMO_FD_MASK);</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  signal_handler(){<br>      /* set osmo_select_* in write-only mode */<br>      osmo_select_mode_set(OSMO_FD_WRITE);<br>  }</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  main() {<br>    while ((osmo_select_mode_get() & OSMO_FD_READ)<br>           || (osmo_select_pending() & OSMO_FD_WRITE))<br>       osmo_select_main_ctx(0);<br>  }</pre><p style="white-space: pre-wrap; word-wrap: break-word;">This idea is a bit more generic, but also a bit more complex to implement.<br>I guess it's feature creep and this current patch set is fine?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/24544">change 24544</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/24544"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib94d4316924103459577087c2214188679db2227 </div>
<div style="display:none"> Gerrit-Change-Number: 24544 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 05 Jun 2021 21:27:28 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>