Change in osmo-ttcn3-hacks[master]: allow ASP_RSL_UD on MSC_ConnHdlr RSL

neels gerrit-no-reply at lists.osmocom.org
Sat Jun 5 20:24:37 UTC 2021


neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24412 )

Change subject: allow ASP_RSL_UD on MSC_ConnHdlr RSL
......................................................................

allow ASP_RSL_UD on MSC_ConnHdlr RSL

In BSC_Tests_VAMOS.ttcn, in f_est_and_reassign_to_secondary_lchan()
there is a missing channel release ack. By allowing ASP_RSL_UD, this rel
ack can be sent trivially.

Change-Id: Icd04184ed87c359349d86c5e0893c2ce9de2f7f1
---
M bsc/BSC_Tests_VAMOS.ttcn
M library/RSL_Emulation.ttcn
2 files changed, 4 insertions(+), 5 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bsc/BSC_Tests_VAMOS.ttcn b/bsc/BSC_Tests_VAMOS.ttcn
index bf487cf..9ecb255 100644
--- a/bsc/BSC_Tests_VAMOS.ttcn
+++ b/bsc/BSC_Tests_VAMOS.ttcn
@@ -451,10 +451,8 @@
 		}
 	[] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr)) {}
 	[] RSL.receive(tr_RSL_RF_CHAN_REL(g_chan_nr)) {
-		/*
 		RSL.send(ts_ASP_RSL_UD(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr),
 				       IPAC_PROTO_RSL_TRX0));
-		*/
 		f_rslem_unregister(0, g_chan_nr, RSL_PROC);
 		g_chan_nr := new_chan_nr;
 		}
@@ -563,10 +561,8 @@
 		}
 	[] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr)) {}
 	[] RSL.receive(tr_RSL_RF_CHAN_REL(g_chan_nr)) {
-		/*
 		RSL.send(ts_ASP_RSL_UD(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr),
 				       IPAC_PROTO_RSL_TRX0));
-		*/
 		f_rslem_unregister(0, g_chan_nr, RSL_PROC);
 		g_chan_nr := new_chan_nr;
 		}
diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn
index 91fa2db..f64329a 100644
--- a/library/RSL_Emulation.ttcn
+++ b/library/RSL_Emulation.ttcn
@@ -85,7 +85,7 @@
 };
 
 type port RSL_DCHAN_PT message {
-	inout RSLDC_ChanRqd, RSL_Message;
+	inout RSLDC_ChanRqd, RSL_Message, ASP_RSL_Unitdata;
 } with { extension "internal" };
 
 type port RSL_CCHAN_PT message {
@@ -638,6 +638,9 @@
 			cid := f_cid_by_comp_ref(vc_conn);
 			IPA_PT.send(ts_ASP_RSL_UD(rx_rsl_msg, ConnectionTable[cid].stream_id));
 			}
+		[bts_role] CLIENT_PT.receive(tr_ASP_RSL_UD(?, sid := ?)) -> value rx_rsl {
+			IPA_PT.send(ts_ASP_RSL_UD(rx_rsl.rsl, rx_rsl.streamId));
+			}
 		[not bts_role] CLIENT_PT.receive(tr_RSL_MsgType(?)) -> value rx_rsl_msg sender vc_conn {
 			cid := f_cid_by_comp_ref(vc_conn);
 			conn_id := f_trx_conn_map_resolve(ConnectionTable[cid].stream_id);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24412
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icd04184ed87c359349d86c5e0893c2ce9de2f7f1
Gerrit-Change-Number: 24412
Gerrit-PatchSet: 15
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210605/b0c5542c/attachment.htm>


More information about the gerrit-log mailing list