<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24412">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">allow ASP_RSL_UD on MSC_ConnHdlr RSL<br><br>In BSC_Tests_VAMOS.ttcn, in f_est_and_reassign_to_secondary_lchan()<br>there is a missing channel release ack. By allowing ASP_RSL_UD, this rel<br>ack can be sent trivially.<br><br>Change-Id: Icd04184ed87c359349d86c5e0893c2ce9de2f7f1<br>---<br>M bsc/BSC_Tests_VAMOS.ttcn<br>M library/RSL_Emulation.ttcn<br>2 files changed, 4 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests_VAMOS.ttcn b/bsc/BSC_Tests_VAMOS.ttcn</span><br><span>index bf487cf..9ecb255 100644</span><br><span>--- a/bsc/BSC_Tests_VAMOS.ttcn</span><br><span>+++ b/bsc/BSC_Tests_VAMOS.ttcn</span><br><span>@@ -451,10 +451,8 @@</span><br><span>              }</span><br><span>    [] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr)) {}</span><br><span>     [] RSL.receive(tr_RSL_RF_CHAN_REL(g_chan_nr)) {</span><br><span style="color: hsl(0, 100%, 40%);">-         /*</span><br><span>           RSL.send(ts_ASP_RSL_UD(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr),</span><br><span>                                   IPAC_PROTO_RSL_TRX0));</span><br><span style="color: hsl(0, 100%, 40%);">-           */</span><br><span>           f_rslem_unregister(0, g_chan_nr, RSL_PROC);</span><br><span>          g_chan_nr := new_chan_nr;</span><br><span>            }</span><br><span>@@ -563,10 +561,8 @@</span><br><span>             }</span><br><span>    [] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr)) {}</span><br><span>     [] RSL.receive(tr_RSL_RF_CHAN_REL(g_chan_nr)) {</span><br><span style="color: hsl(0, 100%, 40%);">-         /*</span><br><span>           RSL.send(ts_ASP_RSL_UD(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr),</span><br><span>                                   IPAC_PROTO_RSL_TRX0));</span><br><span style="color: hsl(0, 100%, 40%);">-           */</span><br><span>           f_rslem_unregister(0, g_chan_nr, RSL_PROC);</span><br><span>          g_chan_nr := new_chan_nr;</span><br><span>            }</span><br><span>diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn</span><br><span>index 91fa2db..f64329a 100644</span><br><span>--- a/library/RSL_Emulation.ttcn</span><br><span>+++ b/library/RSL_Emulation.ttcn</span><br><span>@@ -85,7 +85,7 @@</span><br><span> };</span><br><span> </span><br><span> type port RSL_DCHAN_PT message {</span><br><span style="color: hsl(0, 100%, 40%);">-        inout RSLDC_ChanRqd, RSL_Message;</span><br><span style="color: hsl(120, 100%, 40%);">+     inout RSLDC_ChanRqd, RSL_Message, ASP_RSL_Unitdata;</span><br><span> } with { extension "internal" };</span><br><span> </span><br><span> type port RSL_CCHAN_PT message {</span><br><span>@@ -638,6 +638,9 @@</span><br><span>                      cid := f_cid_by_comp_ref(vc_conn);</span><br><span>                   IPA_PT.send(ts_ASP_RSL_UD(rx_rsl_msg, ConnectionTable[cid].stream_id));</span><br><span>                      }</span><br><span style="color: hsl(120, 100%, 40%);">+             [bts_role] CLIENT_PT.receive(tr_ASP_RSL_UD(?, sid := ?)) -> value rx_rsl {</span><br><span style="color: hsl(120, 100%, 40%);">+                 IPA_PT.send(ts_ASP_RSL_UD(rx_rsl.rsl, rx_rsl.streamId));</span><br><span style="color: hsl(120, 100%, 40%);">+                      }</span><br><span>            [not bts_role] CLIENT_PT.receive(tr_RSL_MsgType(?)) -> value rx_rsl_msg sender vc_conn {</span><br><span>                  cid := f_cid_by_comp_ref(vc_conn);</span><br><span>                   conn_id := f_trx_conn_map_resolve(ConnectionTable[cid].stream_id);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24412">change 24412</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24412"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icd04184ed87c359349d86c5e0893c2ce9de2f7f1 </div>
<div style="display:none"> Gerrit-Change-Number: 24412 </div>
<div style="display:none"> Gerrit-PatchSet: 15 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>