Change in osmo-bts[master]: allow to configure multiple oml remote-ip addresses

pespin gerrit-no-reply at lists.osmocom.org
Thu Jun 3 09:50:01 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24513 )

Change subject: allow to configure multiple oml remote-ip addresses
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/24513/1/src/common/main.c 
File src/common/main.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24513/1/src/common/main.c@402 
PS1, Line 402: LOGP
> fprintf() -> LOGP() is unrelated, let's keep it consistent in this function.
I think it's fine changing this since anyway he's changing lots of lines around this one.


https://gerrit.osmocom.org/c/osmo-bts/+/24513/1/src/common/main.c@419 
PS1, Line 419: BSC
> I suggest to clarify which connection, because together with OML you also have RSL connections: […]
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24513
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I205f68a3a7f35fee4c38a7cfba2b014237df2727
Gerrit-Change-Number: 24513
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 03 Jun 2021 09:50:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210603/5d732b3c/attachment.htm>


More information about the gerrit-log mailing list