Change in osmo-bts[master]: allow to configure multiple oml remote-ip addresses

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jun 2 23:08:44 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24513 )

Change subject: allow to configure multiple oml remote-ip addresses
......................................................................


Patch Set 1:

(5 comments)

Looks good in general, just some minor issues...

https://gerrit.osmocom.org/c/osmo-bts/+/24513/1/src/common/abis.c 
File src/common/abis.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24513/1/src/common/abis.c@252 
PS1, Line 252: 			.timeout_msec = -1, /* infinite (until OS detects error) */
Looks like this change depends on I1c68185120fa2a6c9b6cb8aa2a25232a44ff5508?


https://gerrit.osmocom.org/c/osmo-bts/+/24513/1/src/common/main.c 
File src/common/main.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24513/1/src/common/main.c@402 
PS1, Line 402: LOGP
fprintf() -> LOGP() is unrelated, let's keep it consistent in this function.


https://gerrit.osmocom.org/c/osmo-bts/+/24513/1/src/common/main.c@419 
PS1, Line 419: BSC
I suggest to clarify which connection, because together with OML you also have RSL connections:

  "A-bis/OML connection establishment failed".

Same above.


https://gerrit.osmocom.org/c/osmo-bts/+/24513/1/src/common/vty.c 
File src/common/vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24513/1/src/common/vty.c@514 
PS1, Line 514: 	/* Silently stop when the address is already in the list */
Any reason to tolerate duplicate entries? There may be copy-paste errors in the config file, and here we can help with detecting them by returning CMD_WARNING.


https://gerrit.osmocom.org/c/osmo-bts/+/24513/1/src/common/vty.c@543 
PS1, Line 543: 	if (bsc_oml_host_del) {
Same here, removing a non-existing entry should be considered an error.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24513
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I205f68a3a7f35fee4c38a7cfba2b014237df2727
Gerrit-Change-Number: 24513
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 02 Jun 2021 23:08:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210602/c1bbe1b9/attachment.htm>


More information about the gerrit-log mailing list