This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24271 ) Change subject: iperfserver: adds an offset to the default port. ...................................................................... Patch Set 1: > Patch Set 1: > > > Patch Set 1: Code-Review-1 > > > > I don't really see the point of adding this parameter, it's not really needed, since you can already set the port directly. If you want to count from the default port, then you can easily do something like this: > > srv = IPerf3Server(...) > > srv.set_port(srv.DEFAULT_SRV_PORT + offset) > > Cool I will do as you suggest. I modified the constructor because I'm used to define those values in the constructor instead of a setter function. thanks. If you do not need this patch anymore its best to remove it from the review process by abandon it (menu on the right upper corner). -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24271 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I23f0e5ae599825627a23333a0255577bbc013a3c Gerrit-Change-Number: 24271 Gerrit-PatchSet: 1 Gerrit-Owner: alealcon <alejandro.leal at srs.io> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 02 Jun 2021 16:33:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210602/d741eb75/attachment.htm>